test:add unit tests for DBType and RedisKeyConstants in core module #7874
Conversation
xingfudeshi
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #7874 +/- ##
============================================
- Coverage 71.20% 71.14% -0.06%
Complexity 797 797
============================================
Files 1300 1300
Lines 49620 49620
Branches 5874 5874
============================================
- Hits 35331 35302 -29
- Misses 11371 11403 +32
+ Partials 2918 2915 -3 see 14 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
|
||
| import static org.junit.jupiter.api.Assertions.*; | ||
|
|
There was a problem hiding this comment.
Well done, here are a few suggestions: Please do not use wildcards *
| import static org.junit.jupiter.api.Assertions.*; | ||
|
|
||
| /** |
| */ | ||
| class DBTypeTest { | ||
|
|
There was a problem hiding this comment.
Why is the default access modifier being used here?
|
Please apply |
|
Done! mvn spotless:apply was already applied - no changes needed. The code is already formatted correctly. |
|
Thank you for the review @maple525866! The wildcard imports have been replaced with explicit imports in commit 38060fe. The class uses default (package-private) access modifier because JUnit 5 doesn't require public access for test classes - this is the recommended practice in JUnit 5. However, I've added public modifier for consistency with other test classes in the project. |
|
Please register this PR and your Github ID in change logs. |
4 participants
Closes #6502 - Added unit tests for DBType and RedisKeyConstants to improve test coverage of core module