-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Pipe: Enabled config audit logger & Fixed some checks of config privilege & keep the tree model show pipes aligned with table model's & Fixed the bug that password with "-" prefix cannot be directly entered in Cli #16957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #16957 +/- ##
============================================
+ Coverage 39.32% 39.33% +0.01%
Complexity 212 212
============================================
Files 5053 5053
Lines 337216 337235 +19
Branches 42923 42925 +2
============================================
+ Hits 132603 132665 +62
+ Misses 204613 204570 -43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
CRZbulabula
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL.
| return true; | ||
| } | ||
|
|
||
| public void recordAuditLog(final IAuditEntity auditEntity, final Supplier<String> auditObject) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is a good idea that roughly moving the recordAuditLog function from AuthCheckImpl to AbstractAuditLogger, because the current implementation is only for OBJECT_AUTHENTICATION audit. If u indeed require this refactor, I know current change is for pipe audit, at least rename this interface to recordObjectAuthenticationAuditLog.



Description
As the title said.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR