Skip to content

Conversation

@DMarinhoCodacy
Copy link
Contributor

No description provided.

codacy-production[bot]

This comment was marked as outdated.

Copy link

@codacy-production codacy-production bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Small change: added a files array to the generated ESLint config to include many file extensions (js/jsx/ts/tsx/mjs/cjs/vue). No Codacy issues were raised. Review focuses on correctness, maintainability, and potential missing extensions or escaping concerns.

About this PR

Good to restrict rules to specific file types. Ensure this list matches the project's actual source file types (e.g., .jsx/.tsx usage, .mjs/.cjs presence). Consider centralizing the extensions list if used elsewhere to avoid duplication.
Low risk | High confidence


💡 Codacy uses AI. Check for mistakes.

func CreateEslintConfig(toolsConfigDir string, configuration []domain.PatternConfiguration) error {
result := `export default [
{
files: ["**/*.js", "**/*.jsx", "**/*.ts", "**/*.tsx", "**/*.mjs", "**/*.cjs", "**/*.vue"],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] You added files: ["**/*.js", "**/*.jsx", "**/*.ts", "**/*.tsx", "**/*.mjs", "**/*.cjs", "**/*.vue"]. Confirm that: (1) you want to include both .mjs and .cjs (commonjs vs ESM) — including both is fine but unnecessary if your repo uses only one; (2) any other extensions (e.g. .cts/.mts, .jsx in .tsx projects, or framework specific extensions) are not needed. If this list may grow, extract into a constant or a small helper to keep the template string clearer.

Medium risk | Medium confidence

@codacy-production
Copy link

codacy-production bot commented Dec 11, 2025

Codacy's Analysis Summary

0 new issue (≤ 1 medium issue)
0 new security issue (≤ 0 issue)
0 complexity
0 duplications

Review Pull Request in Codacy →

AI Reviewer available: add the codacy-review label to get contextual insights without leaving GitHub.

@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -0.50%) 100.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6b54110) 5735 1155 20.14%
Head commit (f9a1dfb) 5736 (+1) 1156 (+1) 20.15% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#184) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@DMarinhoCodacy DMarinhoCodacy merged commit cf4ddcc into main Dec 15, 2025
13 of 14 checks passed
@DMarinhoCodacy DMarinhoCodacy deleted the add-files-eslint-config-file branch December 15, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants