Add docker registry credentials store and app-level selection #7790
+796
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
prem-prakash
force-pushed
the
fix-docker-registry-credentials
branch
from
f02e811 to
9496998
Compare
- Remove `required_with` validation rules that caused asymmetric errors - Add explicit null checks after trimming for clearer validation logic - Fix Show component to add errors to both fields when credentials incomplete - Add comprehensive tests for create/edit flows and credential handling - Use stdClass in unit tests to avoid encryption issues Changes: - Create.php: Replace `required_with` with custom validation after trim - Show.php: Combine credential checks to ensure both fields error together - Added DockerRegistryLivewireTest.php with 4 feature tests (24 assertions) - Added ApplicationDeploymentJobDockerRegistryLoginTest.php with 2 unit tests All tests passing (6 tests, 31 assertions). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a Docker registry credentials table and let each application choose a single registry credential for auth during deploys.
Changes