fix: add missing loc, comments, tokens properties in JS
#280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eslint-code-explorer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
lumirlumir
changed the title
loc, comment, tokens properties in JSloc, comments, tokens properties in JS
There was a problem hiding this comment.
Pull request overview
This PR adds support for location information, comments, and tokens in the JavaScript code explorer's AST visualization by enabling additional parsing options in espree. The change aligns the code explorer's behavior with ESLint's default parser configuration.
Key changes:
- Enabled
loc,comment, andtokensoptions in espree parser configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
amareshsm
approved these changes
Dec 27, 2025
lumirlumir
added
the
accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
In this PR, I've added the missing
loc,comments, andtokensproperties to the JavaScript code explorer.In ESLint, the default
espreeparser inserts theloc,comments, andtokensproperties into the resulting AST, as shown in the example below:https://github.com/eslint/eslint/blob/main/lib/languages/js/index.js#L250-L254
However, the Code Explorer's current
espreeparser doesn't include these properties, so working on JavaScript-related features is somewhat inconvenient and the AST appears incorrect because some properties are missing.So, I've enabled the
loc,comments, andtokensoptions inespreeto display these properties. Here's a brief before-and-after comparison:Before
After
What changes did you make? (Give an overview)
In this PR, I've added the missing
loc,comments, andtokensproperties to the JavaScript code explorer.Related Issues
Ref: eslint/eslint#20259
Is there anything you'd like reviewers to focus on?
N/A