Skip to content

Conversation

@Les-Wet
Copy link
Contributor

@Les-Wet Les-Wet commented Dec 24, 2025

Duplicate of 132 and 83. Had to create new PR due to forking issues on GitHub (cannot have more than one fork and forking wilersondevon's repo caused issues for other PR's).

@Les-Wet Les-Wet marked this pull request as draft December 24, 2025 06:52
@Les-Wet
Copy link
Contributor Author

Les-Wet commented Dec 24, 2025

I will start by implementing some of the feedback regarding the coding style, then move on to the tutorial text.

@Les-Wet Les-Wet force-pushed the feature/title-screen branch from de761d8 to aae5cc2 Compare December 27, 2025 15:10
@Les-Wet
Copy link
Contributor Author

Les-Wet commented Dec 27, 2025

In the original PR #83, @CodeWithMa mentioned that this tutorial should use MemCopy since it will follow the Functions section. I have changed main.asm to take this into account. I have also included a build script to build the title-screen files with the new CI/CD that was just merged.

@Les-Wet
Copy link
Contributor Author

Les-Wet commented Dec 27, 2025

@AntonioND also mentioned that input.asm should follow the code style of the rest of the repository regarding indentation. Should this maybe be implemented in a separate PR? The input.asm is taken from the Input section of the tutorial and so there are two copies of the file to edit.

Another point regarding the input.asm file is that in the Input folder of the repository, the file is present but is not necessary for the build. This is because the relevant portion of this file is copied and pasted into main.asm. The build script I just added to the title-screen folder builds both the input.asm and the main.asm files. All other build scripts only use main, should this be changed to stay coherent with the rest of the code in the tutorial or should it simply be explained in the tutorial text?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants