Skip to content

Conversation

@skc7
Copy link
Collaborator

@skc7 skc7 commented Dec 26, 2025

This patch adds support for AMDGPU-specific function attributes for HIP/OpenCL kernels

  • Added setTargetAttributes for AMDGPUTargetCIRGenInfo to set kernel attributes
  • Added generic string attribute handler in amendFunction to translate string-valued extra function attributes to LLVM function attributes

Follows OGCG AMDGPU implementation from "clang/lib/CodeGen/Targets/AMDGPU.cpp".

@skc7 skc7 force-pushed the skc7/cir_attr_amdgpu branch from 6f043a2 to b0994ce Compare December 26, 2025 09:07
@skc7 skc7 marked this pull request as ready for review December 26, 2025 10:44
@skc7
Copy link
Collaborator Author

skc7 commented Dec 27, 2025

All the attributes lowered in this PR are amdgpu llvm backend specific and I think CIR need not have a separate attribute for them at HIP level, (which prevents leakage of LLVM specific things into CIR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant