Skip to content

Conversation

@hduelme
Copy link
Contributor

@hduelme hduelme commented Dec 27, 2025

I added Intellij platform 2025 3 support.
In 2025.3 IntelliJ IDEA Community and Ultimate are combined into one product. See https://blog.jetbrains.com/platform/2025/11/intellij-platform-2025-3-what-plugin-developers-should-know/
Along with this change the build system was updated. See Requirements
I updated the org.jetbrains.intellij.platform plugin incrementally.

This required to update gradle to 8.14.3. For this I followed the instructions on https://docs.gradle.org/9.0.0/userguide/upgrading_version_8.html.

The latest version of org.jetbrains.intellij.platform seems to need more ram in GitHub Action, I increased the RAM to 1024 MB.

Last of all I increased the minimal supported version to 2024.2 (224) and increased the JVM Version to 21.

Copy link
Member

@filiphr filiphr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing @hduelme. Thanks a lot.

I've added one small comment regarding the <=> operator. I didn't know it and I had to look it up. I think adding a small comment about what that if check does would help us a lot down the line. Also there is a conflict now due to me merging that other PRs from you. Can you please fix the conflicts?

@hduelme hduelme force-pushed the intellij-platform-2025-3 branch from 2d4d905 to 4eb629c Compare December 28, 2025 13:25
@hduelme
Copy link
Contributor Author

hduelme commented Dec 28, 2025

@filiphr comment added and merge conflict resolved by rebasing onto the master branch.

We could also consider upgrading Gradle to version 9 in a follow-up PR.

@filiphr filiphr merged commit 1beaba3 into mapstruct:main Dec 28, 2025
7 checks passed
@filiphr
Copy link
Member

filiphr commented Dec 28, 2025

Thanks a lot @hduelme. I've squashed everything and merged it.

We could also consider upgrading Gradle to version 9 in a follow-up PR.

I'm OK upgrading Gradle to version 9. Feel free to do a PR with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants