Fix type parameter leak when using 'this' in reverse mapped types #62931
+152
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62779
Problem
When object literal methods reference
thisinside a function with a reverse mapped type parameter, the type parameterTwas leaking through:Cause
In
getContextualThisParameterType, when computing thethistype for methodb, the code was using the contextual type (the mapped type{ [K in keyof T]: () => T[K] }) with unresolved type parameters. This causedthis.a()to be typed asT["a"]rather than the already-inferrednumber.Solution
When in an inference context, use the actual object literal type via
checkExpressionCached(containingLiteral)rather than the contextual mapped type. This allows methods to see each other's already-inferred types when resolvingthisreferences.Test Plan
reverseMappedThisTypeInference.tsdemonstrating the fix