Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions playwright/_impl/_browser_type.py
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,8 @@ def normalize_launch_params(params: Dict) -> None:
if params["ignoreDefaultArgs"] is True:
params["ignoreAllDefaultArgs"] = True
del params["ignoreDefaultArgs"]
elif params["ignoreDefaultArgs"] is False:
del params["ignoreDefaultArgs"]
if "executablePath" in params:
params["executablePath"] = str(Path(params["executablePath"]))
if "downloadsPath" in params:
Expand Down
29 changes: 29 additions & 0 deletions tests/test_ignore_default_args_bool.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
def test_ignore_default_args_false_is_removed():
# Unit test: no driver/browser needed.
from playwright._impl._browser_type import normalize_launch_params

params = {"ignoreDefaultArgs": False}
normalize_launch_params(params)

assert "ignoreDefaultArgs" not in params
assert "ignoreAllDefaultArgs" not in params


def test_ignore_default_args_true_sets_ignore_all_default_args():
from playwright._impl._browser_type import normalize_launch_params

params = {"ignoreDefaultArgs": True}
normalize_launch_params(params)

assert "ignoreDefaultArgs" not in params
assert params["ignoreAllDefaultArgs"] is True


def test_ignore_default_args_list_is_preserved():
from playwright._impl._browser_type import normalize_launch_params

params = {"ignoreDefaultArgs": ["--mute-audio"]}
normalize_launch_params(params)

assert params["ignoreDefaultArgs"] == ["--mute-audio"]
assert "ignoreAllDefaultArgs" not in params