-
Notifications
You must be signed in to change notification settings - Fork 659
[heft] update storybook plugin to be compatible with v9 #5492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+2,518
−710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a451802 to
14cc4e5
Compare
Also adds support for serve mode detection when using the heft-rspack-plugin
14cc4e5 to
5dbc106
Compare
iclanton
reviewed
Dec 17, 2025
build-tests-samples/heft-storybook-v9-react-tutorial/.storybook/main.js
Outdated
Show resolved
Hide resolved
UberMouse
commented
Dec 18, 2025
Contributor
Author
|
hrm storybook v9 requires node v20+ so the node 18 CI matrix fails |
Member
|
@UberMouse - Node 18 entered EOL in April, so it may be okay to remove. @octogonz - will dropping Node 18 break your stuff? |
Collaborator
Yes, we still have some Rush repos that need to build with Node 18. :'( |
iclanton
approved these changes
Dec 27, 2025
common/changes/@rushstack/heft-storybook-plugin/storybook-v9-support_2025-12-09-01-59.json
Outdated
Show resolved
Hide resolved
common/changes/@rushstack/heft-storybook-plugin/storybook-v9-support_2025-12-09-01-59.json
Outdated
Show resolved
Hide resolved
a027720 to
15cecc1
Compare
15cecc1 to
87d8712
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
binchange from an object pointing at different files depending on whether doing a watch/package build, to a single binary file for both--serveflag when using the heft-rspack-plugin via the same method as the webpack pluginsDetails
3 is not done correctly, when adding a dependency on the heft-rspack-plugin to import the same types as the heft-webpack plugins I started getting the following typescript errors
I'm not really sure what is going on there, so I opted to just drop the dependency and work around the missing types. This was enough to generate a patch for our internal Rush monorepo which is what I am after.
How it was tested
Built the storybook sample project
Impacted documentation
I don't think so?