Prevent flicker when opening a webview in a panel #270777
Open
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to prevent a flicker when it opens
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
CGNonofr
commented
Oct 10, 2025
| } | ||
|
|
||
| protected override showComposite(composite: Composite): void { | ||
| this.layoutEmptyMessage(false); |
Contributor
Author
There was a problem hiding this comment.
The parameter is mandatory, because at that point, this.getActiveComposite() still returns null (for overlay webviews at least)
CGNonofr
pushed a commit
to CodinGame/monaco-vscode-api
that referenced
this pull request
Oct 10, 2025
CGNonofr
pushed a commit
to CodinGame/monaco-vscode-api
that referenced
this pull request
Oct 10, 2025
Member
|
Adding @benibenj for a proper review. |
Member
|
@microsoft-github-policy-service rerun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the empty message div is hidden AFTER the actual webview is layout, the first webview layout occurs while it's placed outside of the workbench (at the bottom on the empty message div).
So another layout is required to place it correctly, leading to a flicker
fix #270776