Add inline reference handling for markdown conversion in RunSubagentTool #285020
+37
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #282509 where inline references (file paths) from subagents were being lost during markdown conversion. The fix ensures that when a subagent returns inline references as part of its response, these references are properly preserved and converted to markdown links in the tool result that gets sent back to the orchestrator.
Key Changes:
- Added handling for
inlineReferencekind in the response processing loop alongsidemarkdownContent - Implemented a new
inlineReferenceToMarkdownfunction to convert inline reference objects into markdown link format - Added necessary imports for URI, basename, and isLocation utilities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add inline reference handling for markdown conversion in RunSubagentTool. Fix #282509
CC: @roblourens