Fix context handling in ChatWidget while re-editing #285099
Open
+13
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes context handling when re-editing chat requests by ensuring that both attachedContext and variables from the current request are included in the context when entering edit mode.
Key Changes
- Refactored inline filtering logic into a reusable
addToContexthelper function - Added deduplication logic using a Set to prevent duplicate context entries when combining
attachedContextandvariables - Fixed bug where
currentElement.variableswas not being added to the editing context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix context handling in ChatWidget while re-editing chat requests.
currentElement.variablesshould be added tocurrentContext. Fix #281766.