Enable "secondary" buttons in all QuickInput locations except Input #285214
+429
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Input is a bit of a beast because of plumbing so I'm saving that for later. Fixes #285213
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables secondary (overflow) buttons in QuickInput components by migrating from ActionBar to ToolBar and adding support for button labels and secondary placement.
Key Changes:
- Replaces ActionBar with ToolBar across QuickInput components (except Input location which is deferred)
- Adds
labelandsecondaryproperties toIQuickInputButtoninterface for overflow menu support - Introduces
quickInputButtonsToActionArraysutility to separate primary and secondary actions
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/vs/platform/quickinput/common/quickInput.ts |
Adds label and secondary properties to IQuickInputButton interface with clear documentation |
src/vs/platform/quickinput/browser/quickInputUtils.ts |
Refactors QuickInputToggleButtonAction to use proper method for run() and adds quickInputButtonsToActionArrays helper function |
src/vs/platform/quickinput/test/browser/quickInputUtils.test.ts |
Comprehensive test suite for quickInputButtonToAction and quickInputButtonsToActionArrays functions |
src/vs/platform/quickinput/browser/tree/quickInputTreeRenderer.ts |
Migrates from ActionBar to ToolBar, updates to use quickInputButtonsToActionArrays for button rendering |
src/vs/platform/quickinput/browser/quickInputList.ts |
Migrates from ActionBar to ToolBar in both item and separator renderers, adds IContextMenuService dependency injection |
src/vs/platform/quickinput/browser/quickInputController.ts |
Migrates left, right, and inline action bars from ActionBar to ToolBar, updates enabled state iteration logic |
src/vs/platform/quickinput/browser/quickInput.ts |
Updates button handling to use quickInputButtonsToActionArrays for all three button locations (left, right, inline) |
src/vs/platform/quickinput/browser/media/quickInput.css |
Updates CSS selectors from child (>) to descendant (space) to accommodate ToolBar's additional wrapper element |
dmitrivMS
approved these changes
Dec 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input is a bit of a beast because of plumbing so I'm saving that for later.
This does two major things:
labelandsecondaryproperty to QuickInputButtons to allow the overflow for particular buttonsFixes #285213 (mostly, will create a new issue for input location when this goes in)