Skip to content

Conversation

@github-actions
Copy link
Contributor

What does this PR do?

Updates libarchive to version v3.8.4

Compare: libarchive/libarchive@9525f90...d114cee

Auto-updated by this workflow

@robobun
Copy link
Collaborator

robobun commented Dec 28, 2025

Updated 7:50 PM PT - Dec 27th, 2025

@RiskyMH, your commit 08fc6ba has 1 failures in Build #33808 (All Failures):


🧪   To try this PR locally:

bunx bun-pr 25726

That installs a local version of the PR into your bun-25726 executable, so you can run:

bun-25726 --bun

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 28, 2025

Walkthrough

The libarchive repository commit hash has been updated in the build configuration, transitioning from 9525f90ca4bd14c7b335e2f8c84a4607b0af6bdf to d114ceee6de08a7a60ff1209492ba38bf9436f79 within the CMake build system.

Changes

Cohort / File(s) Change Summary
Build Configuration Update
cmake/targets/BuildLibArchive.cmake
Updated libarchive COMMIT hash from 9525f90ca4bd14c7b335e2f8c84a4607b0af6bdf to d114ceee6de08a7a60ff1209492ba38bf9436f79

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description covers the primary section 'What does this PR do?' but is missing the required 'How did you verify your code works?' section from the template. Add the 'How did you verify your code works?' section to document the testing or verification performed for this libarchive update.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title clearly and concisely describes the main change: updating libarchive to version v3.8.4, which directly matches the changeset that updates the libarchive commit.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 6b5de25 and 08fc6ba.

📒 Files selected for processing (1)
  • cmake/targets/BuildLibArchive.cmake
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: ShlomoCode
Repo: oven-sh/bun PR: 23515
File: .github/workflows/claude.yml:60-60
Timestamp: 2025-10-12T02:25:02.232Z
Learning: When reviewing GitHub Actions workflows, using semantic version tags (like v1, v2) for official actions from reputable organizations (e.g., actions from github/, anthropics/, etc.) is common and acceptable practice. Don't flag these as security issues requiring commit SHA pinning.
🔇 Additional comments (1)
cmake/targets/BuildLibArchive.cmake (1)

7-7: LGTM! Verified commit corresponds to libarchive v3.8.4.

The commit hash d114ceee6de08a7a60ff1209492ba38bf9436f79 correctly corresponds to libarchive v3.8.4, released on December 1, 2025. This is a bugfix release that addresses:

The existing build configuration is appropriate and requires no changes for this version update.


Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants